[Bug 470727] Review Request: slimdata - Tools and library for reading and writing slim compressed data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470727





--- Comment #14 from Matthew Truch <matt at truch.net>  2009-02-26 09:46:52 EDT ---
(In reply to comment #13)
> 
> Blocker: License field should be GPL+

The included license is GPLv3, and most of the source files don't have a
copyright/license notice.  Is this from the src/crc.h which includes code from
gzip 1.2.4 and has a license notice?  Downloading gzip 1.2.4 indicates that it
is covered by GPLv2.  I guess this is a little more ambiguous than I thought. 
I have contacted upstream about this so they can properly clarify what they
want.  

> Suggestions: please consider preserving timestamps of installed files (adding
> INSTALL="install -p" to make install target in %install section)

Timestamps are preserved already with install -p; for example, see the build
log from my most recent koji scratch build: 
http://koji.fedoraproject.org/koji/getfile?taskID=1159537&name=build.log
Are you seeing a situation where install is called without the -p flag?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.