[Bug 479750] Review Request: libcelt - low-latency compressed audio format for voice and music

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479750





--- Comment #1 from Ray Strode <rstrode at redhat.com>  2009-01-12 17:11:14 EDT ---
The only real issue i see is that you need to

Requires: pkg-config

since you ship .pc files

Other than that, rpmlint gave a few warnings that you may want to fix up:

1) you run make check in %build but normally you'd run that in %check
2) you mix tabs and spaces
3) the tarball in the srpm is 0600 instead of 0644 or whatever
4) You're changelog entry doesn't have a version at the end of it.

Normally you'd do something like:

* Mon Dec 22 2008 Monty Montgomery <monty at xiph.org> 0.5.1-0
- Initial spec file

Last thing I'd bring up is you have an
Epoch: 0
and
Requires: libcelt = %{epoch}:%{version}-%{release}

but often epochs aren't explicitly given unless they're non-zero.

Anyway, the only change you really need afaict is the Requires for pkg-config

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.