[Bug 479750] Review Request: libcelt - low-latency compressed audio format for voice and music

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479750





--- Comment #2 from Monty <cmontgom at redhat.com>  2009-01-12 17:23:52 EDT ---
>The only real issue i see is that you need to
>Requires: pkg-config
>since you ship .pc files

Fixed

>1) you run make check in %build but normally you'd run that in %check

Changed

>2) you mix tabs and spaces

Emacs is doing that mainly because the .emacs file config to make it stop seems
to change every minor release and I'm sick of fixing it every time I update.

>3) the tarball in the srpm is 0600 instead of 0644 or whatever

Changed

4) You're changelog entry doesn't have a version at the end of it.

Fixed

I've refreshed the files at http://people.xiph.org/~xiphmont/CELT with the
above changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.