[Bug 481355] Review Request: nurbs++ - A C++ library to manipulate and create NURBS curves and surfaces.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481355





--- Comment #12 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-07-06 13:20:47 EDT ---
For 3.0.11-4:

* License
  - As spot commented, please change the license
    tag to "LGPLv2+".

* Conditional BuildRequires
-----------------------------------------------------
   274  checking for cppunit-config... no
-----------------------------------------------------
  - cppunit-devel is available on Fedora. Would you try
    to add "BR: cppunit-devel" ?

  - Also configure.in suggests that ImageMagick support
    should be enabled by default. Would you try to
    add "BR: ImageMagick-devel"?

* Man files
----------------------------------------------------
%files
%{_datadir}/man/man1/%{name}-config.1.gz

%files devel
%{_bindir}/nurbs++-config
---------------------------------------------------
　- For macros:
    * Please use %{_mandir} for %{_datadir}/man
    * If you use %{name} macro for %{name}-config.1.gz, please
      also use %{name} in %{_bindir}/nurbs++-config
  Then:
  - %{name}-config.1.gz man file should belong to -devel subpackage,
    not to main package.

* Undefined non-weak symbols
  - $ rpmlint nurbs++ shows lots of rpmlint warnings related to
    undefined non-weak symbols:
---------------------------------------------------
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib11ClassPOvoidIdEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib6MatrixIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib6MatrixIdEE
....
....
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib11ClassPOvoidIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib6MatrixIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib6MatrixIdEE
---------------------------------------------------

    You can see these undefined non-weak symbols also by:
---------------------------------------------------
$ ldd -r /usr/lib/libnurbsd.so.0.1.0 >/dev/null
undefined symbol: _ZTIN4PLib11ClassPOvoidIdEE (/usr/lib/libnurbsd.so.0.1.0)
undefined symbol: _ZTIN4PLib6MatrixIfEE (/usr/lib/libnurbsd.so.0.1.0)
undefined symbol: _ZTIN4PLib6MatrixIdEE (/usr/lib/libnurbsd.so.0.1.0)
.......
---------------------------------------------------
    It seems that
    - libnurbsd.so.0 should be linked also against
      * libmatrix.so
      * libmatrixN.so
      * libmatrixI.so
    - libnurbsf.so should be linked also against
      * The above 3 libraries
      * Also libGL.so, libGLU.so
    For example:
----------------------------------------------------
$
LD_PRELOAD=/usr/lib/libmatrix.so.1:/usr/lib/libmatrixN.so.1:/usr/lib/libmatrixI.so.1:/usr/lib/libGL.so:/usr/lib/libGLU.so
 ldd -r /usr/lib/libnurbsf.so 
 linux-gate.so.1 =>  (0x00c8b000)
 /usr/lib/libmatrix.so.1 (0x007f0000)
 /usr/lib/libmatrixN.so.1 (0x00aaa000)
 /usr/lib/libmatrixI.so.1 (0x00eea000)
 /usr/lib/libGL.so (0x00110000)
 /usr/lib/libGLU.so (0x00ce0000)
 libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x003e5000)
 libm.so.6 => /lib/libm.so.6 (0x008c7000)
 libc.so.6 => /lib/libc.so.6 (0x00184000)
 libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x00b61000)
 libX11.so.6 => /usr/lib/libX11.so.6 (0x004dc000)
 libXext.so.6 => /usr/lib/libXext.so.6 (0x006c2000)
 libXxf86vm.so.1 => /usr/lib/libXxf86vm.so.1 (0x00300000)
 libXdamage.so.1 => /usr/lib/libXdamage.so.1 (0x00327000)
 libXfixes.so.3 => /usr/lib/libXfixes.so.3 (0x00305000)
 libdrm.so.2 => /usr/lib/libdrm.so.2 (0x0030a000)
 libpthread.so.0 => /lib/libpthread.so.0 (0x00c22000)
 libdl.so.2 => /lib/libdl.so.2 (0x00caa000)
 /lib/ld-linux.so.2 (0x00761000)
 libxcb.so.1 => /usr/lib/libxcb.so.1 (0x00730000)
 libXau.so.6 => /usr/lib/libXau.so.6 (0x00bbd000)
 librt.so.1 => /lib/librt.so.1 (0x00315000)
----------------------------------------------------

* %changelog format
  - It is useful in Fedora CVS that one line is put between each %changelog
    entry like:
----------------------------------------------------
* Sat Jun 06 2009 <mycae(a!t)yahoo.com> 3.0.11-4
- Patch to fix build for gcc-4.4
- Add buildrequires to fix autoreconf/libtool command missing in f11 koji

* Sat Jan 24 2009 <mycae(a!t)yahoo.com> 3.0.11-3
- Modified patch to enable opengl build

* Sat Jan 24 2009 <mycae(a!t)yahoo.com> 3.0.11-2
....
----------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.