[Bug 481355] Review Request: nurbs++ - A C++ library to manipulate and create NURBS curves and surfaces.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481355





--- Comment #13 from D Haley <mycae at yahoo.com>  2009-07-07 10:21:54 EDT ---
SPEC URL: http://dhd.selfip.com/427e/nurbs++-5.spec
SRPM URL: http://dhd.selfip.com/427e/nurbs++-3.0.11-5.fc10.src.rpm 


>  - As spot commented, please change the license
>    tag to "LGPLv2+".
Done

>  - Also configure.in suggests that ImageMagick support
>    should be enabled by default. Would you try to
>    add "BR: ImageMagick-devel"?
Done

>- cppunit-devel is available on Fedora. Would you try
>    to add "BR: cppunit-devel" ?

I avoided this as unfortunately their cppunit tests do not compile, and I am
not familiar with that particular framework. I suspect this would requires some
modest level of patching to fix.

====
test_matrix.cpp:150: error: explicit instantiation of 'void
CppUnit::assertEquals(const T&, const T&, CppUnit::SourceLine, const
std::string&) [with T = double]' in namespace 'CppUnit::TestAssert' (which does
not enclose namespace 'CppUnit')
test_matrix.cpp:151: error: explicit instantiation of 'void
CppUnit::assertEquals(const T&, const T&, CppUnit::SourceLine, const
std::string&) [with T = float]' in namespace 'CppUnit::TestAssert' (which does
not enclose namespace 'CppUnit')
test_matrix.cpp:152: error: explicit instantiation of 'void
CppUnit::assertEquals(const T&, const T&, CppUnit::SourceLine, const
std::string&) [with T = int]' in namespace 'CppUnit::TestAssert' (which does
not enclose namespace 'CppUnit')
test_matrix.cpp:155: error: 'NoExceptionExpected' is not a member of 'CppUnit'
test_matrix.cpp:155: error: 'NoExceptionExpected' is not a member of 'CppUnit'
test_matrix.cpp:155: error: wrong number of template arguments (2, should be 1)
re ';' token


et cetera...
====


>    * Please use %{_mandir} for %{_datadir}/man
>    * If you use %{name} macro for %{name}-config.1.gz, please
>      also use %{name} in %{_bindir}/nurbs++-config

Fixed.

>  - %{name}-config.1.gz man file should belong to -devel subpackage,
>    not to main package.

Fixed.

>  - $ rpmlint nurbs++ shows lots of rpmlint warnings related to undefined non-weak symbols:

Odd, my rpmlint (which is up-to-date) does not catch this error. Anyway, its
clearly was problem, and is now Fixed.

[makerpm at box SPECS]$ ldd -r /usr/lib/libnurbsd.so.0.1.0 > /dev/null 
[makerpm at box SPECS]$ 


> - It is useful in Fedora CVS that one line is put between each %changelog
Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.