[Bug 478388] Review Request: UDAV - data visualisation program

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 8 17:22:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478388


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-08 13:22:29 EDT ---
- Preserve time stamps during charset conversion.

- Drop explicit requires.

- Patch thingy looks horrible:
a) it doesn't work if %{_sourcedir} is read-only
b) if the build is stopped in the middle the patch file is lost
and so on.

I suggest either patching first and then sed'ing the resulting file, or running
patch manually:
 sed 's!%%{_docdir}/%%{name}-%%{version}/!%{_docdir}/%{name}-%{version}/!'
%{PATCH1} > patchfile
 patch -p1 < patchfile

- Instead of the looped rm, just run
 find . -name .svn -exec rm -rf {} \;

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list