[Bug 478388] Review Request: UDAV - data visualisation program

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 9 13:54:24 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478388





--- Comment #10 from D Haley <mycae at yahoo.com>  2009-07-09 09:54:23 EDT ---
SPEC URL: http://dhd.selfip.com/427e/udav-0.5.2-1.spec
SRPM URL: http://dhd.selfip.com/427e/udav-0.5.2-1.fc10.src.rpm

>- Instead of the looped rm, just run
> find . -name .svn -exec rm -rf {} \;  
This causes problems with nested .svn files, where find isn't happy if you try
to delete a file that was in a deleted subdir.. Anyway the point is moot as the
.svn files are no longer in the 0.5.2 tarball, so I have removed it entirely.

> - Preserve time stamps during charset conversion.
Fixed.

>- Patch thingy looks horrible:
> ...
>I suggest either patching first and then sed'ing the resulting file, or running
>patch manually:
Done via manual patch. rpmlint now emits a warning, but this can be ignored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list