[Bug 508922] Review Request: scselinux - GUI Code for system-config-selinux, polgen, and lockdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-13 10:24:12 EDT ---
A few blockers:

- You are missing the Source URLs and the project URL.

- Requires: python should be dropped, it is automatically picked up by rpm.

- BuildRequires: python should be BuildRequires: python-devel. Also, use the
sitelib macro at
http://fedoraproject.org/wiki/Packaging:Python
instead of hard coded paths.

- --vendor fedora is not used anymore. If you need to build in RHEL, use
--vendor="".

- Preserve time stamps with install -p.

- You are mixing macro styles. Change the references to $RPM_BUILD_ROOT to
%{buildroot} for consistency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.