[Bug 507943] Review Request: moblin-gtk-engine - GTK engine for Moblin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507943





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-13 10:27:01 EDT ---
rpmlint output:
moblin-gtk-engine.x86_64: W: file-not-utf8
/usr/share/doc/moblin-gtk-engine-0.2.4/README
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

- You need to fix this
http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8
(use the version that preserves the timestamp)


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. NEEDSWORK
- Source URL is missing.
http://fedoraproject.org/wiki/Packaging/SourceURL

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. NEEDSWORK
- Time stamps are lost during install. Adding INSTALL="install -p" as argument
to make install should do the trick.

MUST: A package must own all directories that it creates or require the package
that owns the directory. NEEDSWORK
- Package should own %{_datadir}/themes/Moblin-Netbook/ as it doesn't seem to
be provided by any package. (%{_datadir}/themes is owned by the filesystem
package)

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Missing WORK.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.