[Bug 507943] Review Request: moblin-gtk-engine - GTK engine for Moblin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507943





--- Comment #4 from Peter Robinson <pbrobinson at gmail.com>  2009-07-13 13:08:12 EDT ---
(In reply to comment #3)
> rpmlint output:
> moblin-gtk-engine.x86_64: W: file-not-utf8
> /usr/share/doc/moblin-gtk-engine-0.2.4/README
> 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> - You need to fix this
> http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8
> (use the version that preserves the timestamp)

FIXED

> MUST: The sources used to build the package must match the upstream source, as
> provided in the spec URL. NEEDSWORK
> - Source URL is missing.
> http://fedoraproject.org/wiki/Packaging/SourceURL

FIXED: Updated to the moblin git url for source tarballs. Updated to the latest
release as well. I thought I'd updated this but must have missed it.

> MUST: Optflags are used and time stamps preserved. NEEDSWORK
> - Time stamps are lost during install. Adding INSTALL="install -p" as argument
> to make install should do the trick.

I couldn't find anything about this in packaging guidelines.

> MUST: A package must own all directories that it creates or require the package
> that owns the directory. NEEDSWORK
> - Package should own %{_datadir}/themes/Moblin-Netbook/ as it doesn't seem to
> be provided by any package. (%{_datadir}/themes is owned by the filesystem
> package)

FIXED

> MUST: All relevant items are included in %doc. Items in %doc do not affect
> runtime of application. NEEDSWORK
> - Missing WORK.

Not sure what's missing here. There's no WORK file. I've added the NEWS file.

Updates here
SPEC: http://pbrobinson.fedorapeople.org/moblin-gtk-engine.spec
SRPM: http://pbrobinson.fedorapeople.org/moblin-gtk-engine-0.3.0-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.