[Bug 511196] Review Request: ibus-table-array30 - Array30 Chinese input method for ibus-table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511196





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-14 05:07:37 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1472650
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3d1d3e9bc8e24cfea7af24c30fca8ca940449b46 
ibus-table-array30-1.2.0.20090714-Source.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb (post) scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Should:
1) you should use make install as 
make DESTDIR=%{buildroot} INSTALL="install -p" install

2) License is not clear to me. table text file says its LGPL license.

3) Other ibus-table-* packages are not using cin2ibus.c. Any reason for using
this for this package?

4) also saw other ibus-table-* packages using
export IBUS_TABLE_CREATEDB="%{_bindir}/ibus-table-createdb -o"
in %build.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.