[Bug 511196] Review Request: ibus-table-array30 - Array30 Chinese input method for ibus-table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511196





--- Comment #2 from Ding-Yi Chen <dchen at redhat.com>  2009-07-14 23:33:57 EDT ---
Spec URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-array30.spec
SRPM URL:
http://dchen.fedorapeople.org/files/rpms/ibus-table-array30-1.2.0.20090715-1.fc11.src.rpm


Should:
> 1) you should use make install as 
> make DESTDIR=%{buildroot} INSTALL="install -p" install

Fixed.

> 2) License is not clear to me. table text file says its LGPL license.

Fixed, according to the source .cin file, it should be GPL.

> 3) Other ibus-table-* packages are not using cin2ibus.c.
>  Any reason for using this for this package?
It is my little program that convert tables in cin (for xcin/gcin)
to ibus format. Since ibus-table upstream have not accepted it,
I put it in my package.

> 4) also saw other ibus-table-* packages using 
> export IBUS_TABLE_CREATEDB="%{_bindir}/ibus-table-createdb -o" in %build. 

I put the checking and setting inside CMakeList.
According to documentation of ibus-table, Option -o should be used when
packing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.