[Bug 226063] Merge Review: libXau

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226063


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-07-24 07:04:03 EDT ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1497693
- rpmlint is NOT silent for SRPM and for RPM.
libXau.src: W: name-repeated-in-summary libXau
libXau.src: W: patch-not-applied Patch0: xau-1.0.4-local.patch
libXau.i686: W: name-repeated-in-summary libXau

+ source files match upstream url
d73880b97fc7ddb8d8f59e1cd968337427e20ec2  libXau-1.0.4.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ .pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package  libXau-1.0.4-6.fc12.i686 =>
Provides: libXau.so.6
Requires: libXau.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
rtld(GNU_HASH)
+ Package Processing files: libXau-devel-1.0.4-6.fc12.i686
Provides: pkgconfig(xau) = 1.0.4
Requires: /usr/bin/pkg-config libXau.so.6 pkgconfig(xproto)

Should:
1) fix rpmlint messages
2) follow http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.