[Bug 511204] Review Request: wicd - A wireless and wired network manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511204





--- Comment #6 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-07-30 10:11:02 EDT ---
(In reply to comment #5)
> Created an attachment (id=355670)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=355670) [details]
> my wicd.spec
> 
> I packaged wicd last weekend, just before I found this review. Attaching my
> spec, take what you need from it.  

python-setuptools is version 0.6c9 on F10. Therefore, you should not use a
versioned

BuildRequires: python-setuptools-devel >= 2.4

Also you do not need %dir for claiming ownership, and you should exclude
any useless egg-info.
This is enough, I guess.

%{wicddir}
%{_datadir}/applications/wicd.desktop
%{_datadir}/icons/hicolor/*/apps/wicd-*.*
%{_datadir}/pixmaps/wicd
%{_datadir}/wicd
%{_mandir}/man*/wicd*.gz
%{_sharedstatedir}/wicd

# For noarch packages: sitelib
%{python_sitelib}/%{name}
%exclude %{python_sitelib}/*.egg-info

and why did you comment the noarch?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.