[Bug 511204] Review Request: wicd - A wireless and wired network manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511204





--- Comment #7 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-30 10:36:45 EDT ---
(In reply to comment #6)

> python-setuptools is version 0.6c9 on F10. Therefore, you should not use a
> versioned
> 
> BuildRequires: python-setuptools-devel >= 2.4

You are correct. I thought python-setuptools was built as a subpackage of
python, but it's not. I wanted to require python >= 2.4

> Also you do not need %dir for claiming ownership, 

What %dir statement are you referring to?

The first one is used to prevent accidentally packaging unwanted files in
%{wicddir} and %{wicddir}/backends. We just want python files there. If you
just use %{wicddir}, you wont realize if you accidentally include other files
due to a bad setup.py or a bad tarball.

The other %dir statements in %{_sharedstatedir} are not really needed from a
technical POV, but from a human one. Other packagers should be able to see that
these dirs are empty from a glance at the spec.

> and you should exclude any useless egg-info.

Why is it useless? Are you familiar with
https://fedoraproject.org/wiki/Packaging/Python/Eggs

> %{python_sitelib}/%{name}
> %exclude %{python_sitelib}/*.egg-info

Please don't use excludes, as the break rpm's size calculation.

> and why did you comment the noarch?  

The package itself is noarch, but it cannot be packaged noarch as it puts the
pm-utils script into %{_libdir}. I suggest to package them as a arch'ed
subpackage so the main wicd package can be noarch.

I also suggest to package the GUI and the TUI separately. It would be cool to
have a wireless config tool without X and it would allow users of the GUI to
install wicd without python-urwid.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.