[Bug 495902] Review Request: olpc-kbdshim - grab key and better rotation support for the XO laptop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495902


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #16 from Christoph Wickert <fedora at christoph-wickert.de>  2009-06-05 16:29:09 EDT ---
(In reply to comment #15)
> okay.  from now, the package includes the date and git hash (abbreviated).

excellent

> > I don't have /usr/bin/olpc-brightness. What package is it from?
> 
> yikes!  good catch.  

The whole time I had the feeling that something was missing. ;) I'm very keen
on the brightness script because I need it for LXDE and Xfce as well. But to be
honest I'm a little disappointed, the script could be more sophisticated IMHO,
e. g. it could read max brightness from
/sys/class/backlight/dcon-bl/max_brightness. Take a look at
http://www.catmoran.com/olpc/#xfcebrvo

olpc-brightness is being run as root because of the permissions of
/sys/class/backlight/dcon-bl/brightness, right? Is there no better way? Can we
use hal to give user write permission?

Anyway, testing was positive, everything works as you described. So let's check
the outstanding issues:

OK - MINOR: BuildRoot tag
OK - MAJOR: BuildArch tag
OK - MAJOR: Requires: hal added
OK - MINOR: Description: line breaks are at 80 characters
OK - MAJOR: RPM_OPT_FLAGS are honored
OK - MAJOR: Timestamps preserved

I just realized that "BuildArch: %{ix86}" is not a good idea because the
buildsys will then build for i386, i486, i586, i686 and athlon. Better use 
ExclusiveArch: %{ix86}

One last thing: during build I see:
+ make
fatal: Not a git repository
fatal: Not a git repository
fatal: Not a git repository
fatal: Not a git repository
fatal: Not a git repository

I wouldn't call this a blocker, but please fix it. 


olpc-kbdshim-6-2.20090605git98f5b2c.src.rpm is APPROVED

P.S.: Please cc me if you submit olpc-powerd for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.