[Bug 504430] Review Request: healpy - A python wrapper of the healpix library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504430





--- Comment #13 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-13 05:19:40 EDT ---
rpmlint output:
healpy.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/healpy/_healpy_sph_transform_lib.so 0775
healpy.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/healpy/_healpy_pixel_lib.so 0775
healpy.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/healpy/_healpy_fitsio_lib.so 0775
3 packages and 0 specfiles checked; 3 errors, 0 warnings.

- Fix the permissions, they should be 755.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK

MUST: The package must be named according to the Package Naming Guidelines.
NEEDSWORK
- This is a python module, so the correct name is python-healpy.

MUST: The spec file name must match the base package %{name}. OK
- Remember to change this as well.

MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- GPLv2+ license headers are now present and correctly picked up by
licensecheck.pl
- The test file test/test_fit_dipole.py is still missing a license. This is not
a problem per se, since the license of the package is already clear from the
other files.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add ChangeLog and test/test_fit_dipole.py to %doc.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSWORK
- License file is still missing.

SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.