[Bug 504430] Review Request: healpy - A python wrapper of the healpix library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504430





--- Comment #14 from Joseph Smidt <josephsmidt at gmail.com>  2009-06-16 22:57:20 EDT ---
(In reply to comment #13)
> rpmlint output:
> healpy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.6/site-packages/healpy/_healpy_sph_transform_lib.so 0775
> healpy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.6/site-packages/healpy/_healpy_pixel_lib.so 0775
> healpy.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.6/site-packages/healpy/_healpy_fitsio_lib.so 0775
> 3 packages and 0 specfiles checked; 3 errors, 0 warnings.
> 
> - Fix the permissions, they should be 755.
> 

This is so weird.  On my system they are 755 so rpmlint isn't complaining. 
However, I have forced them to by 755 so Done.



> MUST: The package must be named according to the Package Naming Guidelines.
> NEEDSWORK
> - This is a python module, so the correct name is python-healpy.

Sorry, I didn't know this is a hard rule since the python modules it depends
on, numpy, scipy and pyfits don't follow it. 

However fixed: Done.



> SHOULD: If the package does not include license text(s) as separate files from
> upstream, the packager should query upstream to include it. NEEDSWORK
> - License file is still missing.

It turns out the COPYING file is in the directory containinh Healpix-c++ which
I was deleting.  It is now copied to %%doc.  Done

The new files are again at:
Spec URL: http://jsmidt.fedorapeople.org/healpy.spec
SRPM URL: http://jsmidt.fedorapeople.org/python-healpy-0.9.6.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.