[Bug 506755] Review Request: tmux - a terminal multiplexer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506755





--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-21 14:14:08 EDT ---
(In reply to comment #7)
> Hello Jussi!  Thank you for your comments.
> 
> "- If you need to redefine the prefix and mandir then the makefile probably
> doesn't support DESTDIR, which should be fixed in the first place."
> 
> It does support DESTDIR, but sets PREFIX to /usr/local.  Here is a snippet from
> the unpatched makefile:

Right. This program doesn't use autotools and thus the prefix is not set by
%configure. OK.

> install:
>         $(INSTALLDIR) $(DESTDIR)$(PREFIX)/bin
>         $(INSTALLBIN) $(PROG) $(DESTDIR)$(PREFIX)/bin/$(PROG)
>         $(INSTALLDIR) $(DESTDIR)$(PREFIX)/man/man1
>         $(INSTALLMAN) $(PROG).1 $(DESTDIR)$(PREFIX)/man/man1/$(PROG).1
> 
> So I think this patch is necessary to insert $MANDIR in the relevant places and
> then PREFIX and MANDIR can be defined at make install.  The spec uses
> DESTDIR=$RPM_BUILD_ROOT too.

Yes, also the man should go to $(PREFIX)/share/man/man1/ instead of
$(PREFIX)/man/man1.


> "- You don't need a patch to set the man page permissions, you can just chmod
> it
> after the install. (You can contact upstream about them, though.)"
> 
> That patch also removes some ownership bits as well:
> 
>  PREFIX?= /usr/local
>  INSTALLDIR= install -d
> -INSTALLBIN= install -g bin -o root -m 555
> -INSTALLMAN= install -g bin -o root -m 444
> +INSTALLBIN= install -p
> +INSTALLMAN= install -p -m 644
> 
> Perhaps the patch should remove the ownership/permission bits entirely and like
> you say I can chmod the man page to 644 -- I guess I would do that in %files? 

You should be able to override these with
 make install PREFIX=%{_prefix} MANDIR=%{_mandir} DESTDIR=$RPM_BUILD_ROOT
INSTALLBIN="install -p -m 755" INSTALLMAN="install -p -m 644"
instead of patching. But yes, the install command shouldn't specify a user or a
group.

> "- What happens if you don't use patch2? Doesn't -I work as well as -iquote..?"
> 
> It fails to build in i386 and PPC.  Some other distributions make the same kind
> of patch (Arch Linux and Debian, IIRC).

Interesting. You saw this with a koji scratch build?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.