[Bug 506755] Review Request: tmux - a terminal multiplexer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506755





--- Comment #9 from Chess Griffin <chess at chessgriffin.com>  2009-06-21 17:19:44 EDT ---
About man going (In reply to comment #8) 
> > install:
> >         $(INSTALLDIR) $(DESTDIR)$(PREFIX)/bin
> >         $(INSTALLBIN) $(PROG) $(DESTDIR)$(PREFIX)/bin/$(PROG)
> >         $(INSTALLDIR) $(DESTDIR)$(PREFIX)/man/man1
> >         $(INSTALLMAN) $(PROG).1 $(DESTDIR)$(PREFIX)/man/man1/$(PROG).1
> > 
> > So I think this patch is necessary to insert $MANDIR in the relevant places and
> > then PREFIX and MANDIR can be defined at make install.  The spec uses
> > DESTDIR=$RPM_BUILD_ROOT too.
> 
> Yes, also the man should go to $(PREFIX)/share/man/man1/ instead of
> $(PREFIX)/man/man1.

Yes, the fixmanpagedir patch does this:

diff -up tmux-0.8/GNUmakefile.fixmanpagedir tmux-0.8/GNUmakefile
--- tmux-0.8/GNUmakefile.fixmanpagedir  2009-06-15 21:30:09.000000000 -0400
+++ tmux-0.8/GNUmakefile        2009-06-15 21:30:47.000000000 -0400
@@ -65,6 +65,7 @@ LDFLAGS+=
 LIBS+= -lncurses

 PREFIX?= /usr/local
+MANDIR?= ${PREFIX}/man
 INSTALLDIR= install -d
 INSTALLBIN= install -p
 INSTALLMAN= install -p -m 644
@@ -137,8 +138,8 @@ depend: $(SRCS)
 install:
        $(INSTALLDIR) $(DESTDIR)$(PREFIX)/bin
        $(INSTALLBIN) $(PROG) $(DESTDIR)$(PREFIX)/bin/$(PROG)
-       $(INSTALLDIR) $(DESTDIR)$(PREFIX)/man/man1
-       $(INSTALLMAN) $(PROG).1 $(DESTDIR)$(PREFIX)/man/man1/$(PROG).1
+       $(INSTALLDIR) $(DESTDIR)$(MANDIR)/man1
+       $(INSTALLMAN) $(PROG).1 $(DESTDIR)$(MANDIR)/man1/$(PROG).1

 clean:
        rm -f $(CLEANFILES)

This does not change the default upstream locations allows passing MANDIR at
make install.

> You should be able to override these with
>  make install PREFIX=%{_prefix} MANDIR=%{_mandir} DESTDIR=$RPM_BUILD_ROOT
> INSTALLBIN="install -p -m 755" INSTALLMAN="install -p -m 644"
> instead of patching. But yes, the install command shouldn't specify a user or a
> group.
> 

Okay, I can try that instead.  Thanks!

> > "- What happens if you don't use patch2? Doesn't -I work as well as -iquote..?"
> > 
> > It fails to build in i386 and PPC.  Some other distributions make the same kind
> > of patch (Arch Linux and Debian, IIRC).
> 
> Interesting. You saw this with a koji scratch build?  

Yep:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1416014

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.