[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493246


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(liangsuilong at gmai
                   |                            |l.com)




--- Comment #14 from Jan Klepek <jan.klepek at hp.com>  2009-06-21 18:28:03 EDT ---
1] why do you have download_version different from Version?
from specfile:
%define  download_version 0.70
Name:           shutter
Version:        0.70.2
Why don't use Version instead of download_version?

2] in %install you are creating directory named "0755" in bin/ and share/

3] after install you have following directories in
/usr/share/shutter/resources:
pofiles: tar.gz-ed files from application, why do you need them here? 
modules: File, Proc perl modules, as they mostly have separate packages (except
File::Spec and Proc::Simple which is still present in codes and seems that it
is required in case that you want to cancel operation), you have to use
packaged version of them.
Please create packages for missing dependencies (File::Spec and Proc::Simple).

Koji build isn't only one thing which is required before package is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.