[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493246


Liang Suilong <liangsuilong at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(liangsuilong at gmai |
                   |l.com)                      |




--- Comment #15 from Liang Suilong <liangsuilong at gmail.com>  2009-06-22 01:21:08 EDT ---
(In reply to comment #14)
> 1] why do you have download_version different from Version?
> from specfile:
> %define  download_version 0.70
> Name:           shutter
> Version:        0.70.2
> Why don't use Version instead of download_version?

The real version is 0.70.2, but the tarball of source code which author
provides is shutter-0.70. I do not know why the author do it. Maybe we should
contract with author and persuade him to correct the version.  

> 2] in %install you are creating directory named "0755" in bin/ and share/

Are there any problems? I think it is OK for us.

> 3] after install you have following directories in
> /usr/share/shutter/resources:
> pofiles: tar.gz-ed files from application, why do you need them here? 
> modules: File, Proc perl modules, as they mostly have separate packages (except
> File::Spec and Proc::Simple which is still present in codes and seems that it
> is required in case that you want to cancel operation), you have to use
> packaged version of them.
> Please create packages for missing dependencies (File::Spec and Proc::Simple).
> 
> Koji build isn't only one thing which is required before package is approved.  

In my opinion, these directories in /usr/share/shutter/resources: 

1. pofiles: maybe they should be remove. Let me have a try! If it is OK, I will
remove them.

2. modules: It is not a good choice to remove them as I see. If we remove them,
we will need to create packages for (File::Spec and Proc::Simple). If
(File::Spec and Proc::Simple) upgrade to new version, it will be not compatible
with shutter. So I think we should use the perl module which author offers.
Just like some linux software with static libraries, It can provide the best
compatibility with their software. 

Yes, I know koji build is an important thing which is require before package is
approved, but not the only one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.