[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #6 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-06 14:16:12 EDT ---
ok, here are my notes:

- rpmlint says:
   iax-devel.x86_64: W: no-documentation
but there is not much we can do about it

- the patch is trivial but seems packaging specific. I leave it up to you to
send it upstream.

* I couldn't check the URL. It doesn't respond.

* I think the file iax-config.in needs sed'ded because it assumes the libdir to
be $prefix/lib/

? I suggest making use of the %name macro. Up to you

* You might want to kill the rpath

* Shouldn't the license field be GPL+ and LGPL+, because some source files are
GPL, some are LGPL?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.