[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol
bugzilla at redhat.com
bugzilla at redhat.com
Fri Mar 6 21:25:30 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454008
--- Comment #7 from Tom "spot" Callaway <tcallawa at redhat.com> 2009-03-06 16:25:29 EDT ---
(In reply to comment #6)
> ok, here are my notes:
>
> - rpmlint says:
> iax-devel.x86_64: W: no-documentation
> but there is not much we can do about it
Indeed.
> * I couldn't check the URL. It doesn't respond.
Fixed it to point to the download toplevel dir for iax.
> * I think the file iax-config.in needs sed'ded because it assumes the libdir to
> be $prefix/lib/
You're right. Fixed in -2.
> ? I suggest making use of the %name macro. Up to you
I did it everywhere except the libiax.so references.
> * You might want to kill the rpath
I don't see any bad rpath... /usr/lib/rpm/check-rpaths says it is clean.
> * Shouldn't the license field be GPL+ and LGPL+, because some source files are
> GPL, some are LGPL?
Good catch.
New Spec URL: http://auroralinux.org/people/spot/review/coccinella/iax.spec
New SRPM URL:
http://auroralinux.org/people/spot/review/coccinella/iax-0.2.2-2.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list