[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501006





--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-05-15 12:33:50 EDT ---
Some notes:

* About Patch1
  - Would you explain why you want to change Name= item
    from "xine" to "Xine"?

?? About dlopen'ing libX11.so in src/aaui/main.c
  - ... however:
--------------------------------------------------------
[tasaka1 at localhost bin]$ ldd -r ./aaxine  | grep libX11
 libX11.so.6 => /usr/lib/libX11.so.6 (0x00793000)
--------------------------------------------------------
    I may be wrong, however would you explain why this
    dlopen() is really needed?

* Timestamps
  - Add INSTALL="install -p" on 'make install' to keep timestamps
    on installed files

* desktop-file-install
  - You don't have to delete desktop file under %_builddir
    (--delete-original). Note that currently
    $ rpmbuild -bi --short-circuit will fail due to this.

* Scriptlets
  - Update GTK icon cache update scriptlets:
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

* %files
  - Would you explain why two different desktop files are installed
    under different places?
----------------------------------------------------------
/usr/share/applications/xine.desktop
/usr/share/xine/desktop/xine.desktop
----------------------------------------------------------
    Note that these two differs slightly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.