[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501006





--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-15 14:58:40 EDT ---
(In reply to comment #1)
> Some notes:
> 
> * About Patch1
>   - Would you explain why you want to change Name= item
>     from "xine" to "Xine"?

Good question. This was in the rpmfusion package. I dropped the patch
altogether.

> ?? About dlopen'ing libX11.so in src/aaui/main.c
>   - ... however:
> --------------------------------------------------------
> [tasaka1 at localhost bin]$ ldd -r ./aaxine  | grep libX11
>  libX11.so.6 => /usr/lib/libX11.so.6 (0x00793000)
> --------------------------------------------------------
>     I may be wrong, however would you explain why this
>     dlopen() is really needed?

I don't know, this is from the rpmfusion package and I don't know why it is
necessary. The sed is needed however since the unversioned .so file is provided
by libX11-devel instead of libX11.

> * Timestamps
>   - Add INSTALL="install -p" on 'make install' to keep timestamps
>     on installed files

Fixed, thanks for the reminder (I was going to fix this earlier but forgot).

I also fixed the charset conversion to preserve timestamps.


> * desktop-file-install
>   - You don't have to delete desktop file under %_builddir
>     (--delete-original). Note that currently
>     $ rpmbuild -bi --short-circuit will fail due to this.

Done.

> * Scriptlets
>   - Update GTK icon cache update scriptlets:
>     https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

This was already partly done, but I rewrote the part to use the snippets above.
Also added the missing mimetype refresh.

> 
> * %files
>   - Would you explain why two different desktop files are installed
>     under different places?
> ----------------------------------------------------------
> /usr/share/applications/xine.desktop
> /usr/share/xine/desktop/xine.desktop
> ----------------------------------------------------------
>     Note that these two differs slightly.  

Good question. Removed the other one.


http://theory.physics.helsinki.fi/~jzlehtol/rpms/xine-ui.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/xine-ui-0.99.5-8.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.