[Bug 500476] Review Request: cups-bjnp- cups backend for Canon bjnp (USB over IP) printers
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 22 16:04:27 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500476
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-05-22 12:04:25 EDT ---
For -2:
* tarball
- Tarball in your srpm does not match which can be downloaded
from the URL written as %SOURCE0:
------------------------------------------------------------------
117082 2009-05-17 05:00 cups-bjnp-0.5.3.tar.gz
139933 2009-05-19 05:59 cups-bjnp-0.5.3-2.fc10.src/cups-bjnp-0.5.3.tar.gz
------------------------------------------------------------------
* Macros
- Please use macros for standard directories.
/usr should be either %_prefix or %_exec_prefix:
https://fedoraproject.org/wiki/Packaging/RPMMacros
* %defattr
- Now we recommend %defattr(-,root,root,-)
* Directory ownership issue
- %_exec_prefix/lib/cups/backend (defined as %cups_backend_dir)
is already owned by cups rpm and this package should
not own this directory itself
! Note that
------------------------------------------------------------------
%files
%{cups_backend_dir}
------------------------------------------------------------------
contains all files/directories under %cups_backend_dir and
the directory %cups_backend_dir itself
As this directory is owned by cups (and currently this
package Requires cups-libs but not cups), add
"Requires: cups" to resolve directory ownership issue.
* Documents
- As Igor pointed out on the comment 6, "INSTALL" file
is not likely to be needed.
* %changelog
- And modify %changelog entry
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list