[Bug 500476] Review Request: cups-bjnp- cups backend for Canon bjnp (USB over IP) printers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500476





--- Comment #8 from Louis Lagendijk <louis at lagendijk.xs4all.nl>  2009-05-29 17:50:48 EDT ---
(In reply to comment #7)
Thanks for the review. I have been on a short holiday, hence the delay in
responding

I believe I have now fixed all your comments:

> For -2:
> 
> * tarball
>   - Tarball in your srpm does not match which can be downloaded
>     from the URL written as %SOURCE0:
>
Ok, fixed this. Released 0.5.4 upstream and used that to make the new spec file

> * Macros
>   - Please use macros for standard directories.
>     /usr should be either %_prefix or %_exec_prefix:
>     https://fedoraproject.org/wiki/Packaging/RPMMacros
> 

Done

> * %defattr
>   - Now we recommend %defattr(-,root,root,-)
> 

Done

> * Directory ownership issue
>   - %_exec_prefix/lib/cups/backend (defined as %cups_backend_dir)
>     is already owned by cups rpm and this package should
>     not own this directory itself
>     ! Note that
> ------------------------------------------------------------------
> %files
> %{cups_backend_dir}
> ------------------------------------------------------------------
>       contains all files/directories under %cups_backend_dir and
>       the directory %cups_backend_dir itself
>     As this directory is owned by cups (and currently this
>     package Requires cups-libs but not cups), add
>     "Requires: cups" to resolve directory ownership issue.
> 

Thanks, completely missed this. Fixed!

> * Documents
>   - As Igor pointed out on the comment 6, "INSTALL" file
>     is not likely to be needed.
> 

Done, INSTALL removed

> * %changelog
>   - And modify %changelog entry  
Done

New versions available:
Spec URL: http://www.fazant.net/cups-bjnp/cups-bjnp.spec
SRPM URL: http://www.fazant.net/cups-bjnp/cups-bjnp-0.5.4-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.