[Bug 519521] Review Request: kompozer - Web Authoring System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519521





--- Comment #8 from Jason Tibbitts <tibbs at math.uh.edu>  2009-11-08 12:41:33 EDT ---
OK, this does build for me.  I'm not really ready to review this; it will
probably take work my more than one person.  But I do have some comments:

Source0: should be a URL, so that spectool -g will work if possible.  I don't
suppose there's a URL for the manpage, but if there is then you should inclide
that as well.

I'm not sure what the nvu-related Provides: and Obsoletes: is about; is nvu
available in any Fedora repository currently?

You have Requires(pre): desktop-file-utils, but no %pre scriptlet at all. 
Similarly, you call update-desktop-database and ldconfig in %post and %postun,
but have no dependencies for them.

This provides a whole lot of libraries that are also provided by xulrunner.  I
think this is a significant problem.  Seamonkey manages to avoid this by
turning off the dependency generator and managing some of the dependency
generation itself.  I can't really offer any suggestions on how to do it
properly, though I'd bet the firefox/xulrunner/seamonkey maintainers (all the
same people) would have some suggestions.

The correct set of Fedora compiler flags are not used, and the debuginfo
package seems to be broken.  These are related.  You will need to get the
propler set of compiler flags (from %{optflags}) passed to the compiler. 
Seamonkey seems to do this properly.

The biggest issue I see, however, is that this is basically yet another forked 
mozilla.  Distributing a forked copy of something that's updated with security
issues once a week isn't something we should go about lightly; I'd want to see
discussion with the firefox/xulrunner maintainers and probably FESCo as well
(the latter due to the requirements of the no-bundled-libraries policy).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.