[Bug 462458] Review Request: drupal-workspace - Allows users to have a central place to view and manage their content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462458


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu>  2009-11-08 13:42:41 EDT ---
I'm back to looking over ancient review tickets again.  Again, I know zilch
about dupal, but nobody else has looked at this in 14 months and fortunately
the package still seems to be current, so....

Note that you no longer need BuildRoot: or the first line of %install in
Fedora.  You can probably remove them unless someone plans to update to drupal
6 in EPEL.

The license in the spec is still GPLv2, though it seems as though you intended 
to change it.

* source files match upstream.  sha256sum:                             
   d2defb65cc4572a24869dd0ff2d67c4876e2307b649a52b94cc16d7b2e858002
   workspace-6.x-1.4-rc1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   drupal-workspace = 6.x.1.4-0.rc1.fc12
  =
   drupal >= 6.0

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.