[Bug 532874] Review Request: xorg-x11-drv-wacom - Xorg X11 wacom input driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532874


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #7 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-17 14:49:27 EDT ---
REVIEW:

Good:
- spec legible
- %global is used
- correct spec name
- compiler optflags are in %configure
- no static libs
- %clean section exists
- removing .la files
- BR/R are ok
- buildroot ok
- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1812867
- License GPLv2+ ok, but no license text, see should items.
- source match upstream, both md5 91af5fab1637c6ce52e3f9418d53e22b
- Groups ok
- %files section is ok, except missing docs see below


Needswork:
- permissions not ok, see rpmlint
- rpmlint: $ rpmlint xorg-x11-drv-wacom.spec
xorg-x11-drv-wacom-0.10.0-1.fc12.src.rpm x86_64/xorg-x11-drv-wacom-*
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/xf86WacomDefs.h
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmCommon.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmCompat.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmConfig.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/xf86Wacom.h
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/xf86Wacom.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmUSB.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmISDV4.c
xorg-x11-drv-wacom-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xf86-input-wacom-0.10.0/src/wcmFilter.c
xorg-x11-drv-wacom-devel.x86_64: W: summary-ended-with-dot Xorg X11 wacom input
driver development package.
xorg-x11-drv-wacom-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 11 warnings.

  * for the spurious permission:
    e.g. run in %prep: find -type f -name '*.c' | xargs chmod -x
  * no-documentation  in devel is ignorable

- no documentation in main package:
  There is AUTHORS, ChangeLog, README.

_____________________

Should:
- xorg-x11-drivers requires linuxwacom. When this package is build, the drivers
package should require this one instead.
- Add a the license text upstream and add it to %doc, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
- devel package just contains text files -> should be noarch

You should bump the release and change the changelog, when you make changes to
the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.