[Bug 532874] Review Request: xorg-x11-drv-wacom - Xorg X11 wacom input driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532874





--- Comment #8 from Peter Hutterer <peter.hutterer at redhat.com>  2009-11-17 20:50:47 EDT ---
Thanks for the review, items are addressed:

http://people.freedesktop.org/~whot/xorg-x11-drv-wacom.spec
http://people.freedesktop.org/~whot/xorg-x11-drv-wacom-0.10.0-2.fc12.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=1813431

Changes (this time with changelog in specfile):
- Obsolete linuxwacom, don't Conflict with it.
- Remove trailing dot from summary (rpmlint warning).
- Remove spurious executable bits from source files (rpmlint warning).
- Add AUTHORS, ChangeLog, README to doc

For the reasons outlined in Comment #3, I think it's better to obsolete
linuxwacom instead of just conflicting with it. This should also solve the
issue with xorg-x11-drivers (though I will update that to require
xorg-x11-drv-wacom).

> - rpmlint: $ rpmlint xorg-x11-drv-wacom.spec
This didn't give me any of the warnings when I ran it here, is there a specific
flag I have to provide?

> - Add a the license text upstream and add it to %doc, see
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

done, file was already upstream, just missed out on being included in the
tarball. Will be in the next version.

> - devel package just contains text files -> should be noarch

noarch requires installing the .pc file into _datadir to avoid 64-bit
conflicts. This again seems to require upstream changes and is a bit iffy
anyway in light of all the other xorg-x11-drivers installing into _libdir.
This should be cleaned up in one go across all drivers to maintain consistency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.