[Bug 526928] Review Request: blokkal - A KDE blogging client that supports multiple protocols and sites

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526928





--- Comment #4 from Rex Dieter <rdieter at math.unl.edu>  2009-10-13 15:21:46 EDT ---
Source checksum:
6a93b0207269cfa645d4d186797f984d  Blokkal-0.1.1.tar.bz2

macro usage: OK
scriptlets: OK


Comments.

1.  %check:
Though, I'm fairly sure your adjustments there are largely legit, would be
preferable if those sed/patches were in %prep section.  (upstream has been
contacted?)

Guidelines-wise, .desktop validation is only required for stuff under
%_datadir/applications/

So, you really only want this in %check:
desktop-file-validate
%{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop


2.  Source0 URL should be:
http://downloads.sourceforge.net/sourceforge/blokkal/files/Blokkal-%{version}.tar.bz2


3.  No need for these in both main and -libs (preferably keep only in main
pkg):
%doc AUTHORS COPYING INSTALL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.