[Bug 526928] Review Request: blokkal - A KDE blogging client that supports multiple protocols and sites

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526928





--- Comment #5 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-13 16:56:11 EDT ---
(In reply to comment #4)
> Source checksum:
> 6a93b0207269cfa645d4d186797f984d  Blokkal-0.1.1.tar.bz2

  6a93b0207269cfa645d4d186797f984d  Blokkal-0.1.1.tar.bz2 same here

> macro usage: OK
> scriptlets: OK
> 
> 
> Comments.
> 
> 1.  %check:
> Though, I'm fairly sure your adjustments there are largely legit, would be
> preferable if those sed/patches were in %prep section.  (upstream has been
> contacted?)

Upstream has been contacted. Martin Müller committed the changes to svn and
they will be included in the next release.
I removed the sed trickery for now, since it's not making any difference for
blokkal.

> Guidelines-wise, .desktop validation is only required for stuff under
> %_datadir/applications/
> 
> So, you really only want this in %check:
> desktop-file-validate
> %{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop

Fixed

> 2.  Source0 URL should be:
> http://downloads.sourceforge.net/sourceforge/blokkal/files/Blokkal-%{version}.tar.bz2

Whoops, fixed.

> 3.  No need for these in both main and -libs (preferably keep only in main
> pkg):
> %doc AUTHORS COPYING INSTALL  

Fixed as well. Forgot to remove the dupes.

Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec
SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.1-5.fc10.src.rpm

[thomas at tusdell ~]$ rpmlint rpmbuild/SPECS/blokkal.spec
rpmbuild/SRPMS/blokkal-0.1.1-5.fc10.src.rpm rpmbuild/RPMS/x86_64/blokkal-*-5*
blokkal-libs.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1745214

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.