[Bug 517858] Review Request: RackTables - RackTables is a datacenter asset management system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517858


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-09 14:03:21 EDT ---
Well, I don't know how to use this package, however:

* Summary
---------------------------------------------------------
RackTables.noarch: W: name-repeated-in-summary RackTables
---------------------------------------------------------
  - On Fedora now we think that repeating the package's name in
    Summary is just redundant.

* License
  - All scripts are under GPLv2 and its compat licenses. However
    this package also includes some "contents" and are under
    CC-BY-SA.
    I think showing contents' license is preferable, so I recommend
    to "GPLv2 and CC-BY-SA" as license tag.

* About /usr/share/RackTables/inc/secret.php:
----------------------------------------------------------
RackTables.noarch: E: file-in-usr-marked-as-conffile
/usr/share/RackTables/inc/secret.php
RackTables.noarch: E: non-readable /usr/share/RackTables/inc/secret.php 0660
RackTables.noarch: E: zero-length /usr/share/RackTables/inc/secret.php
----------------------------------------------------------
  - The latter 2 rpmlint errors (non-readable and zero-length) are perhaps
    by intention, however just to be clear would you explain if these
    are as you expect?

  - The first one rpmlint error should be fixed. All configuration files
    should be under %{_sysconfdir}.
    If this file needs to be under %{_datadir}/%{name}/inc, you should
    * Create %{_sysconfdir}/%{name} directory
    * Put secret.php under %{_sysconfdir}/%{name}
    * And create a symlink of %{_datadir}/%{name}/inc/secret.php which
      points to %{_sysconfdir}/%{name}/secret.php.

* spec file cleanup
-----------------------------------------------------------
mkdir -p $RPM_BUILD_ROOT%{_docdir}
-----------------------------------------------------------
  - What is this line for?
  ! Note
    "%doc COPYING" entry in %files
    - first removes %buildroot%_defaultdocdir/%{name}-%{version}
    - then creates %buildroot%_defaultdocdir/%{name}-%{version}
    - and installs files specified by %doc to 
      %buildroot%_defaultdocdir/%{name}-%{version}

* %files
  - build.log says:
-----------------------------------------------------------
    80  warning: File listed twice: /usr/share/RackTables/inc/secret.php
-----------------------------------------------------------
    In the spec file, this file is actually listed as twice:
-----------------------------------------------------------
%files
%attr(660,root,apache) %config(noreplace) %{_datadir}/%{name}/inc/secret.php
%{_datadir}/%{name}/*
-----------------------------------------------------------
    Please fix this so that this file is listed only once in the
    spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.