[Bug 517858] Review Request: RackTables - RackTables is a datacenter asset management system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517858





--- Comment #6 from Colin Coe <colin.coe at gmail.com>  2009-09-09 20:20:44 EDT ---
Hi and thank you for another detailed, constructive review.

- Removed redundant 'RackTables' from the summary and description.
- Changed license as suggested.
- Put secret.php into /etc/RackTables (I've found that it doesn't have to be
empty) and created symlink back to %{_datadir}/%{name}/inc.
- Removed 'mkdir -p $RPM_BUILD_ROOT%{_docdir}'
- Stopped listing inc/secret.php twice.

[build at rpm02 ~]$ rpmlint
/var/lib/mock/hp-rhel-5-x86_64/root/builddir/build/SPECS/RackTables.spec
/var/lib/mock/hp-rhel-5-x86_64/result/*rpm
RackTables.noarch: W: dangling-relative-symlink
/usr/share/RackTables/inc/secret.php ../../etc/RackTables/secret.php
RackTables.noarch: W: incoherent-version-in-changelog 0.17.4-4 0.17.4-4.el5
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[build at rpm02 ~]$

Not sure how to address the 'dangling symlink' warning.

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-4.src.rpm

Thanks again

CC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.