[Bug 522933] Review Request: pyicq-t - ICQ Transport for Jabber Servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522933





--- Comment #7 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-14 10:34:42 EDT ---
Spec URL: http://www.seekline.net/fedora/pyicq-t.spec
SRPM URL: http://www.seekline.net/fedora/pyicq-t-0.8.1.5-2.fc11.src.rpm

Created a new RPM for some minor changes. For example, added the requirement
shadow-utils like indicated here:
https://fedoraproject.org/wiki/Packaging:UsersAndGroups

% rpmlint pyicq-t-mysql-0.8.1.5-2.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

% rpmlint pyicq-t-0.8.1.5-2.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

% rpmlint pyicq-t-0.8.1.5-2.fc11.noarch.rpm 
pyicq-t.noarch: W: non-standard-uid /var/run/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /var/run/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-uid /etc/pyicq-t/config.xml pyicqt
pyicq-t.noarch: W: non-standard-gid /etc/pyicq-t/config.xml pyicqt
pyicq-t.noarch: E: non-readable /etc/pyicq-t/config.xml 0600
pyicq-t.noarch: W: non-standard-uid /var/spool/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /var/spool/pyicq-t pyicqt
pyicq-t.noarch: E: non-standard-dir-perm /var/spool/pyicq-t 0700
pyicq-t.noarch: W: non-standard-uid /etc/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /etc/pyicq-t pyicqt
pyicq-t.noarch: E: non-standard-dir-perm /etc/pyicq-t 0700
pyicq-t.noarch: W: doc-file-dependency
/usr/share/doc/pyicq-t-0.8.1.5/managessi.py /usr/bin/env
pyicq-t.noarch: W: doc-file-dependency
/usr/share/doc/pyicq-t-0.8.1.5/migrate.py /usr/bin/env
pyicq-t.noarch: W: doc-file-dependency
/usr/share/doc/pyicq-t-0.8.1.5/managessi.py R
pyicq-t.noarch: W: doc-file-dependency
/usr/share/doc/pyicq-t-0.8.1.5/migrate.py R
pyicq-t.noarch: W: no-reload-entry /etc/rc.d/init.d/pyicq-t
1 packages and 0 specfiles checked; 3 errors, 13 warnings.

I guess the warnings non-standard-{g,u}id and errors non-standard-dir-perm can
be ignored. The config files in /etc/pyicq-t shouldn't be readable by any other
user because they contain clear text passwords. The daemon spool files under
/var/spool/pyicq-t contain all clear text passwords for all clients. Therefore
it shouldn't be readable too.

I'm unsure about the doc-file-dependency warning. Since /usr/bin/env will be
available on all other systems, my guess is that we can ignore this too. Or
what does the crowd say?

Additionally the warning no-reload-entry can be ignored too, or does it? Not
every daemon needs a reload entry, right?

For the last two warnings I couldn't find something in here:
https://fedoraproject.org/wiki/Common_Rpmlint_issues

So I'm not 100% sure what to do.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.