[Bug 522933] Review Request: pyicq-t - ICQ Transport for Jabber Servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522933


Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com




--- Comment #8 from Michael Schwendt <mschwendt at gmail.com>  2009-09-14 11:09:06 EDT ---
> pyicq-t.noarch: W: no-reload-entry /etc/rc.d/init.d/pyicq-t

https://fedoraproject.org/wiki/Packaging:SysVInitScript#Required_Actions

> pyicq-t.noarch: W: doc-file-dependency

"rpmlint -i ..." explains this.

> -%defattr(-,root,root,-)
> +%defattr(0644,root,root,0755)

AFAIK, this doesn't improve anything (contrary to the %attr usage).

[...]

* The "config.patch" doesn't match with the initscript and spec file. Please
review carefully.

* The rpmdiff against pyicq-t-0.8.1.3-2 reveals two 
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.