[Bug 522933] Review Request: pyicq-t - ICQ Transport for Jabber Servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522933





--- Comment #10 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-14 15:07:18 EDT ---
Spec URL: http://www.seekline.net/fedora/pyicq-t.spec
SRPM URL: http://www.seekline.net/fedora/pyicq-t-0.8.1.5-4.fc11.src.rpm

In https://fedoraproject.org/wiki/Packaging:SysVInitScript a couple of
suggestions are made for a proper init script. I followed some and changed the
file, e.g. the return/exit codes are now much better (exit 2 if invalid
arguments, exit 5 if no exec file, exit 6 if no config file).

% rpmlint pyicq-t.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

% rpmlint pyicq-t-0.8.1.5-4.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

% rpmlint pyicq-t-mysql-0.8.1.5-4.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

% rpmlint pyicq-t-0.8.1.5-4.fc11.noarch.rpm 
pyicq-t.noarch: W: non-standard-uid /var/run/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /var/run/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-uid /etc/pyicq-t/config.xml pyicqt
pyicq-t.noarch: W: non-standard-gid /etc/pyicq-t/config.xml pyicqt
pyicq-t.noarch: E: non-readable /etc/pyicq-t/config.xml 0600
pyicq-t.noarch: W: non-standard-uid /var/spool/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /var/spool/pyicq-t pyicqt
pyicq-t.noarch: E: non-standard-dir-perm /var/spool/pyicq-t 0700
pyicq-t.noarch: W: non-standard-uid /etc/pyicq-t pyicqt
pyicq-t.noarch: W: non-standard-gid /etc/pyicq-t pyicqt
pyicq-t.noarch: E: non-standard-dir-perm /etc/pyicq-t 0700
1 packages and 0 specfiles checked; 3 errors, 8 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.