[Bug 522933] Review Request: pyicq-t - ICQ Transport for Jabber Servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522933





--- Comment #9 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-14 13:40:05 EDT ---
Spec URL: http://www.seekline.net/fedora/pyicq-t.spec
SRPM URL: http://www.seekline.net/fedora/pyicq-t-0.8.1.5-3.fc11.src.rpm

(In reply to comment #8)
> > pyicq-t.noarch: W: no-reload-entry /etc/rc.d/init.d/pyicq-t
> 
> https://fedoraproject.org/wiki/Packaging:SysVInitScript#Required_Actions

Yeah added try-restart, reload and force-reload to the init script.

> > pyicq-t.noarch: W: doc-file-dependency
> 
> "rpmlint -i ..." explains this.

Jep, removed the execution permissions.

> > -%defattr(-,root,root,-)
> > +%defattr(0644,root,root,0755)
> 
> AFAIK, this doesn't improve anything (contrary to the %attr usage).

I added the 0644 perms because I wanted to circumvent the problem with a couple
of files which where accidentally labelled as executables. Now I changed that
and do a chmod in the %install section. Additionally I will inform upstream.
Maybe they want to change this too. Because the executable files don't have a
sha-bang, so no real intention to execute them.

> * The "config.patch" doesn't match with the initscript and spec file. Please
> review carefully.

Argl, your right. A typo which I looked over and over.

> * The rpmdiff against pyicq-t-0.8.1.3-2 reveals two 
> https://fedoraproject.org/wiki/Packaging:UnownedDirectories  

Hmm, I can't reproduce this. Can you tell me your exact commands?

The latest changes are in release 3.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.