[Bug 475852] Review Request: gnustep-base - GNUstep Base library package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475852





--- Comment #30 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-14 20:00:54 EDT ---
Koji F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1679163

There are a couple of minor things to fix (see below), and this package is on
the way in. I forgot -- are you a sponsored maintainer? If not, set this to
block FE-NEEDSPONSOR and I'll certify that I'll sponsor you.

MUST

FIX rpmlint
gnustep-base.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)

You can fix this with Emacs' "untabify" command

OK package name
OK spec file name
OK package guideline-compliant
OK license complies with guidelines
FIX license field accurate
  some files are actually GPLv3+, while others are still GPLv2+. This means
  the aggregate is GPLv3+. Most LGPL files are v2+ but some (makefiles! should
  these not be GNU public domain ?!) are LGPLv3+. Assuming that upstream
  intention is to switch files to (L)GPLv3+ as they are updated, I think we
  can say "LGPLv3+ and GPLv3+". If you could email upstream and get a
  clarification, and put a comment with the URL to the upstream mail from a
  mailing list archive, that would be great.

  The other alternative is to split out the v2 and v3 files, but that would be 
  crazy if the division is merely temporal, rather than functional (i.e. if
  there is no distinct subpackage with a different license)
OK license file not deleted
OK spec in US English
FIX spec legible
  - the comment for renaming pl mentions pllit but the file is renamed to
    pllist.
OK source matches upstream
$ md5sum gnustep-base-1.18.0.tar.gz ../SOURCES/gnustep-base-
1.18.0.tar.gz                                                                   
880491e0fc64ab3507887f43faa67572  gnustep-base-1.18.0.tar.gz
880491e0fc64ab3507887f43faa67572  ../SOURCES/gnustep-base-1.18.0.tar.gz

OK builds under >= 1 archs, others excluded
  see Koji link
FIX build dependencies complete
  gmp-devel listed twice
  /usr/bin/iconv is bad for two reasons:
  - we frown on file-based dependencies because they can be expensive to
resolve
  - it is part of glibc-common which is always installed
OK library -> ldconfig
FIX own all directories
  gnustep-base-devel should additionally requires gnustep-make:
  - it is a development package, and is useless without the other makefiles
  - it installs into %{_libdir}/GNUstep/Makefiles/Additional which is owned
    by gnustep-make
OK no dupes in %files
  note: just a style thing, but %doc is normally put just under %defattr, not
  at the bottom.
OK permission
OK %clean RPM_BUILD_ROOT
OK macros used consistently
OK Package contains code
OK headers in -devel
OK if libfiles are suffixed, the non-suffixed goes to devel
OK devel requires versioned base package
OK clean buildroot before install
OK filenames UTF-8

SHOULD
OK package build in mock on all architectures
  see Koji link
? package functioned as described
  will test with Oolite later
OK scriplets are sane
FIX require package not files
  see above (iconv)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.