[Bug 475852] Review Request: gnustep-base - GNUstep Base library package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475852





--- Comment #31 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-14 20:08:49 EDT ---
And the rpmlint result from the binary RPMs:

$ rpmlint gnustep-base*
gnustep-base.x86_64: W: hidden-file-or-dir
/usr/lib64/GNUstep/Libraries/gnustep-base/Versions/1.18/Resources/NSTimeZones/.README.swp
gnustep-base.x86_64: E: non-standard-executable-perm /usr/bin/gdomap 01755
gnustep-base-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 1 errors, 2 warnings.


hidden-file: that should be deleted in %install
gdomap: is there a reason for the sudo?

The documentation warning is.. interesting. Could you see how gnustep-make does
its documentation subpackage, and create a gnustep-base-doc subpackage? It'd be
easier than gnustep-make's, since gnustep-make will already be installed when
you start the build process (e.g. you can do 'make -C Documentation' in %build,
not delay it to %install)

Also, there is the 'Examples' directory. That should probably be not be built,
but packaged as part of gnustep-base-devel, complete with the relevant
makefiles, e.g.

%files devel
...
%doc Examples

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.