[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #6 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-24 09:14:43 EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Tabs aligned properly. Just you use another tab with (see first post).
> > 
> > I red your first comment and just wanted to encourage you to use "normal" tabs
> > or 8 whitespaces. I guess this not a big problem but why do you want to go a
> > different why than most of the other packages? In a very strict sense this may
> > fell under
> > https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_note-5
> No "most of the other"!!!
> I tired say about it. There was discussion on this theme -
> http://thread.gmane.org/gmane.linux.redhat.fedora.extras.packaging/6214/focus=6224
> And accordingly it proposed draft guidelines change -
> https://fedoraproject.org/wiki/PackagingDrafts/Tabs
> So, until it is not part Guidelines it can not be required.

You pointed to the right discussion and if you read the last few posts you will
see my point of view.

> > Then why not write a patch and wrap it with a conditional for 64bit like you
> > already mentioned? This would solve it.
> Sed also solve problem. So, I have opposite question - why I should write
> additionally patch? And what of benefit of it over sed solution??

Like I already said e.g. if a new release is made available extra attention
should always go to the sed line because sed my return without an error even
when it didn't change a single bit. A patch would automate this. It would fail
and raise an error. What about the next ten upstream releases? If they change
the line e.g. from

install(TARGETS net7ssh LIBRARY DESTINATION lib)

to

install(TARGETS net7ssh LIBRARY DESTINATION LIB)

your sed section wouldn't fail and build fine e.g. on PPC. But then you should
really make sure that you tested your package on every supported architecture.
I'm not sure if it's worth that. If you submit your package to koji and
automatically build for all supported architectures then koji would raise an
error for 64bit. I would say it is more clean. But that's up to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.