[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 24 13:27:11 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #7 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-09-24 09:27:10 EDT ---
(In reply to comment #6)
> You pointed to the right discussion
I known :)

> and if you read the last few posts you will see my point of view.
You also known my point. I think its all now. I do not see any problem change
tab width if you want in any editor what you like.

I think you favorite editor can do it. If not, I wrote
little script for that on PHP:
http://hubbitus.net.ru/rpm/Fedora11/x11vnc/tab-convert.phps

Yo may use it like:
$ cat ne7ssh.spec | ./tab-convert.php > x11vnc.spec.spaces

Or, with power of UNIX-WAY, off course directly in shell f.e:
$ cat ne7ssh.spec | php -r 'define("TAB_WIDTH", 5);foreach(file("php://stdin")
as $l){preg_match_all("/\t+/", $l, $m, PREG_OFFSET_CAPTURE);foreach($m[0] as
$mm){$l = str_replace($mm[0],str_repeat(" ", (TAB_WIDTH - ($mm[1] % TAB_WIDTH))
+ (  TAB_WIDTH * ( strlen($mm[0]) - 1 )  )), $l);}echo $l;}' >
ne7ssh.spec.spaces

> Like I already said e.g. if a new release is made available extra attention
> should always go to the sed line because sed my return without an error even
[snip]
> I'm not sure if it's worth that. If you submit your package to koji and
> automatically build for all supported architectures then koji would raise an
> error for 64bit. I would say it is more clean. But that's up to you.  
Yes, there no problem in any case, because koji build fails in case if
something changed there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list