[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #8 from Michael Schwendt <mschwendt at gmail.com>  2009-09-24 16:31:01 EDT ---
Only those "sed" transformations, which would fail to substitute something
silently _without_ causing the package build to fail with errors, are
dangerous. In this case, however, on 64-bit multiarch targets the files would
be installed into /lib and not found by %{_lib} in the %files section. A
failing sed would lead to rpmbuild errors. That's okay.

[...]

About the -examples sub-package:

> I think external package give more flexibility to user in any case.  

So? What flexibility would that be? First of all, it requires the -devel
package. Second, the -devel package requires the main package. Third, the
included Makefile explicitly links with libbotan, so a dependency on
botan-devel is missing => ne7ssh-devel is missing "Requires: botan-devel" as
its headers include botan headers. Fourth, one cannot install the -example
package like a separate -doc package to peruse the source code. Fifth, the
examples are stored in their own directory instead of together with the API
documentation. Sixth, the examples are just 25K uncompressed. Seventh, the base
ne7ssh package contains 1.7M of API %doc files. Better split those files into a
-doc package. It's covered by the guidelines even.

Convinced? I hope so. ;o)

[...]

The package %description doesn't explain what the package contains. A first
sentence like the %summary is missing. Don't assume that %summary and
%description are displayed above eachother.

There is typo in the %description:  s/it's/its/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.