[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment
bugzilla at redhat.com
bugzilla at redhat.com
Sun Jan 3 10:55:52 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551878
Terje Røsten <terjeros at phys.ntnu.no> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |terjeros at phys.ntnu.no
--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2010-01-03 05:55:51 EDT ---
Some comments:
a) you can remove python from req, pygtk2 will pull that, drop commas too.
b) spell out the file names in %files
c) you have to handle the desktop file:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
d) Drop INSTALL from %doc
e) why is these needed: %attr(0755,root,root) and %attr(0644,root,root) in
%files needed?
f) never seen _datarootdir used before, why not _datadir?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list