[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551878





--- Comment #2 from Jean-Francois Saucier <jfsaucier at infoglobe.ca>  2010-01-03 13:18:51 EDT ---
Spec URL: http://jfsaucier.fedorapeople.org/packages/font-manager.spec
SRPM URL:
http://jfsaucier.fedorapeople.org/packages/font-manager-0.4.2-2.fc12.src.rpm


> a) you can remove python from req, pygtk2 will pull that, drop commas too.

Done.

> b) spell out the file names in %files

Done for some files (bindir and .desktop). I have a small question here. For
example, I have %{_datadir}/font-manager/* that glob many files. Do I need to
list all of them or the glob is alright in this case?

> c) you have to handle the desktop file

Didn't know of that one. Thanks for the pointer, I think it is solved now.

> d) Drop INSTALL from %doc

Done.

> e) why is these needed: %attr(0755,root,root) and %attr(0644,root,root) in %files needed?

I removed the %attr(0755,root,root) because this was not necessary. But if I
remove the %attr(0644,root,root) one, the .desktop file get installed 0755.

> f) never seen _datarootdir used before, why not _datadir?

Fixed, I didn't see _datadir when I grep rpmbuild --showrc the first time.



Also, I added this in %file section because the folder was not removed cleanly
after a rpm -e :

%dir %{_datadir}/font-manager/



Thank you very much for the help!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.