Wiki Patch

[Dimitris Glezos]

O/H Thomas Chung έγραψε:
> On 4/25/07, Mike McGrath <mmcgrath at redhat.com> wrote:
>> Ricky Zhou wrote:
>> >
>> > In the kindofblue theme, the sidebar is absolutely positioned, which
>> > makes it overlap/cover the footer on short pages (e.g.
>> > http://fedoraproject.org/wiki/Websites/Join?action=info).
>> >
>> > I've made a quick patch to switch to a float-based layout and avoid
>> this
>> > problem.  The patch also replaces "sidebar-header" (purely
>> > presentational markup) with a background-image on #header (this
>> required
>> > me to alter wiki-sidebar-header.png slightly).
>> >
>> > I've put the relevant files up here:
>> > http://fedoraproject.org/wiki/RickyZhou/kindofblue
>> >
>> > Side note: I just joined this group yesterday, so please let me know if
>> > there are any tasks that I can look at/get involved in.
>>
>> As long as I get the ok from one of the 'website regulars' I'll commit
>> this and import it.  Thomas, karsten, patrick, glezos?  anyone?
> 
> I'm no expert on this area but It looks good to me. :)
> Dimitris, please review the the patch be we commit.

Patch seems OK to me; thanks for the initiative & patch Ricky. :)

The new `wiki-sidebar-header.png` has slightly different colors than the
original and the `repeat-y` property makes it look ragged. Ricky, could you
please create one which has a consistent blue color across the x-axis and make
it 5px high instead of 1?

After you commit the changes to our CVS (you have write acess AFAICT), I can
then double-check them out locally to make sure everything is OK and ask Mike to
make the final CVS changes live.

-d


-- 
Dimitris Glezos
Jabber ID: glezos at jabber.org, GPG: 0xA5A04C3B
http://dimitris.glezos.com/

"He who gives up functionality for ease of use
loses both and deserves neither." (Anonymous)
--