[feedhenry-dev] Review request for fh-fhc PR

Wojciech Trocki wtrocki at redhat.com
Thu Nov 24 12:50:40 UTC 2016


Going to check and merge this now.

On Thu, Nov 24, 2016 at 12:42 PM, Martin Murphy <mmurphy at redhat.com> wrote:

> Hi folks,
> The PR has been reviewed, who can merge it, before it needs to be rebased
> again?
>
> Cheers,
> M.
>
> On 23 November 2016 at 13:50, Martin Murphy <mmurphy at redhat.com> wrote:
>
>> Thanks Wojtek,
>> In the "Reviewing changes" section of the help repo, it says:
>>
>>> Note: if you have write access to the repository, do not directly merge
>>> pull requests. Let another team member review your pull request and approve
>>> it.
>>
>>
>> Can you merge it also?
>>
>> Cheers,
>> M.
>>
>>
>> On 22 November 2016 at 18:30, Wojciech Trocki <wtrocki at redhat.com> wrote:
>>
>>> Thanks for contribution. It's reviewed now.
>>>
>>> On Tue, Nov 22, 2016 at 5:27 PM, Martin Murphy <mmurphy at redhat.com>
>>> wrote:
>>>
>>>> Hi folks,
>>>> is anyone able to review a PR to fh-fhc? [1]
>>>> It fixes HHTP Proxy server support - FH-2856 [2]
>>>>
>>>> Cheers,
>>>> M.
>>>>
>>>>
>>>> [1] https://github.com/feedhenry/fh-fhc/pull/268
>>>> [2] https://issues.jboss.org/browse/FH-2856
>>>>
>>>> _______________________________________________
>>>> feedhenry-dev mailing list
>>>> feedhenry-dev at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/feedhenry-dev
>>>>
>>>
>>>
>>>
>>> --
>>> Wojciech Trocki
>>> Software Engineer, Red Hat Mobile
>>>
>>>
>>
>


-- 
Wojciech Trocki
Software Engineer, Red Hat Mobile
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/feedhenry-dev/attachments/20161124/58b3dc06/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.png
Type: image/png
Size: 11472 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/feedhenry-dev/attachments/20161124/58b3dc06/attachment.png>


More information about the feedhenry-dev mailing list