[Freeipa-devel] PATCH: fixes LDAP driver searches

[Simo Sorce]

On Mon, 2009-08-03 at 13:34 -0400, Stephen Gallagher wrote:
> On 08/03/2009 01:18 PM, Simo Sorce wrote:
> > Stupid typo was making all searches just vanish in thin air.
> > Should work fine with this patch.

> Nack.
> 
> You're testing if(ret==EOK) below the switch statement, but it's not
> initialized, and it's only set for
>     case LDAP_RES_BIND:
>     case LDAP_RES_SEARCH_RESULT:
>     case LDAP_RES_MODIFY:
>     case LDAP_RES_ADD:
>     case LDAP_RES_DELETE:
>     case LDAP_RES_MODDN:
>     case LDAP_RES_COMPARE:
>     case LDAP_RES_EXTENDED:
>     case LDAP_RES_INTERMEDIATE:

Right, that check is actually not really needed anymore.
Attached patch that changes the code so that the useless check is
removed.

Simo.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-search-replies-getting-ignored.patch
Type: application/mbox
Size: 1995 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090803/77e92e24/attachment.mbox>